Improper Digest Verification in httpsig-hyper May Allow Message Integrity Bypass
Impact
An issue was discovered in httpsig-hyper where Digest header verification could incorrectly succeed due to misuse of Rust's matches! macro. Specifically, the comparison:
```rust
if matches!(digest, _expected_digest)
```
treated _expected_digest as a pattern binding rather than a value comparison, resulting in unconditional success of the match expression.
As a consequence, digest verification could incorrectly return success even when the computed digest did not match the expected value.
Applications relying on Digest verification as part of HTTP message signature validation may therefore fail to detect message body modification. The severity depends on how the library is integrated and whether additional signature validation layers are enforced.
Patches
This issue has been fixed in:
The fix replaces the incorrect matches! usage with proper value comparison and additionally introduces constant-time comparison for digest verification as defense-in-depth.
Regression tests have also been added to prevent reintroduction of this issue. Users are strongly advised to upgrade to the patched version.
Workarounds
There is no reliable workaround without upgrading. Users who cannot immediately upgrade should avoid relying solely on Digest verification for message integrity and ensure that full HTTP message signature verification is enforced at the application layer.
References
- PR: https://github.com/junkurihara/httpsig-rs/pull/14
- Follow-up hardening and test additions: https://github.com/junkurihara/httpsig-rs/pull/15
